Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show info about configured timezone in footer #78

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Show info about configured timezone in footer #78

merged 3 commits into from
Mar 18, 2024

Conversation

podliashanyk
Copy link
Contributor

Closes #61

@podliashanyk podliashanyk added the beta Part of beta release label Mar 11, 2024
@podliashanyk podliashanyk self-assigned this Mar 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

Test results

  4 files    4 suites   7s ⏱️
14 tests 14 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit b51c85e.

♻️ This comment has been updated with latest results.

hmpf
hmpf reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually use the timezone-config anywhere? What is changed if we set timezone = 'LOCAL'?

.. and when was the docs in the README added!?

@podliashanyk
Copy link
Contributor Author

Do we actually use the timezone-config anywhere? What is changed if we set timezone = 'LOCAL'?

.. and when was the docs in the README added!?

Forgot to connect to a closed PR #60

If you change to LOCAL then timestamps will be displayed in your local time (as opposed to UTC). F.e. there is an hour difference for all timestamps if I choose UTC vs LOCAL

@podliashanyk podliashanyk mentioned this pull request Mar 14, 2024
Closed
2 tasks
@podliashanyk podliashanyk requested a review from hmpf March 14, 2024 14:15
@podliashanyk podliashanyk merged commit 5ca4757 into main Mar 18, 2024
5 checks passed
@podliashanyk podliashanyk deleted the display-timezone-info branch March 18, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

@johannaengland johannaengland Awaiting requested review from johannaengland

Assignees

@podliashanyk podliashanyk

Labels
beta Part of beta release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make timezone configurable
2 participants
@podliashanyk @hmpf